Colin Alworth

Un-imported GwtQuery on the classpath causes errors

5

A strict project without an `` statements on Query but with an `` on RequestFactory will fail to compile. Since `com.google.web.bindery.requestfactory.shared.gquery.PromiseRF` lives in the RequestFactory package and extends `com.google.gwt.query.client.plugins.deferred.Deferred.DeferredPromiseImpl`, when...

Widgets.asElement does not wire up events

1

This is probably going to be tricky to get right, so it might be worth making this into a documentation bug, rather than a fault in the library. A GWT...

Generic closure `@interface` types emit create() factory methods with raw return type

1

A specific example of this is `elemental2.dom.CustomEventInit`, which at least as of elemental2 1.1.0 is generic on `T`, but the factory method is raw: ``` @JsType(isNative = true, namespace =...

Operating on non-externs?

5

I'm experimenting with taking [Closure-annotated](https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler) JS (both hand-written and generated from TypeScript via [tsickle](https://github.com/angular/tsickle/)). I was surprised to discover that when the generator runs, it only emits jsinterop types that...

@JsEnum types cannot be used in a union

15

Steps to repro - use an externs file with an enum that is referenced by a union type. Roughly: ``` /** * @enum {number} */ foo.bar.SomeEnum = { ONE: 0,...

(Discovered while testing #46) Given this JS, the expected behavior presently is that `_STATIC` will be appended to the `static` version since these would otherwise collide. Instead, we see a...

Given two members on a class, one static and one instance, one will be generated with a `_STATIC` suffix. That is, ``` Foo.noArgMethod = function() {}; Foo.prototype.noArgMethod = function() {};...

@typedef on a property fails to build

1

Example JS, as put in the externs/modules/modules.js file: ``` /** * @typedef {(string|number|boolean)} */ baz.structural; ``` Results in this stack trace: ``` Exception in thread "main" java.lang.UnsupportedOperationException at com.google.javascript.rhino.jstype.Property.getScope(Property.java:185) at...

Allowing a generated project to depend on another generated project (like elemental2)

1

Technically I did get this to work, but it seems awkward, and so I am probably using jsinterop-generator or bazel wrong, or both. I have a new git repo of...

Global scope is always assumed to be "window"

4

ModelHelper.createGlobalJavaType always assumes that `window` is the correct name to use: ``` public static Type createGlobalJavaType(String packagePrefix, String globalScopeClassName) { Type type = new Type(NAMESPACE); type.setName(globalScopeClassName); type.setPackageName(packagePrefix); type.setNativeNamespace(GLOBAL_NAMESPACE); type.addAnnotation( builder()...