nilmtk-contrib icon indicating copy to clipboard operation
nilmtk-contrib copied to clipboard

Update and fix examples

Open PMeira opened this issue 4 years ago • 3 comments

They don't run as-is and there are some other problems reported in other issues.

We should also remove the PS Dataport or reduce its use in the examples due to issues reported in https://github.com/nilmtk/nilmtk/issues/873

PMeira avatar Dec 31 '20 22:12 PMeira

@PMeira @levaphenyl I can help with writing the notebooks. Just, one quick question. Currently, we have nilmtk-contrib which is under-development and nilmtk-contrib which is hosted on anaconda cloud.

For which of these nilmtk-contrib versions should I start writing the tutorial notebooks? Also, the same issue exists with NILMTK. Post, completion I can send a PR.

Also, I think we can use REDD dataset and DRED dataset. We can also link the notebooks for making REDD.h5 and DRED.h5.

Hopefully, that will make it easier to use the toolkit

Rithwikksvr avatar Jan 11 '21 20:01 Rithwikksvr

The development version would be better. If that works for you without major issues, we can release another version (maybe after #37?), with a matching NILMTK.

the same issue exists with NILMTK. Post, completion I can send a PR.

Yep, I believe I just copied the notebook at the time.

Also, I think we can use REDD dataset and DRED dataset. We can also link the notebooks for making REDD.h5 and DRED.h5.

OK. From https://github.com/nilmtk/nilmtk/pull/850, AMPds2 includes a HDF5. If that works, it could also be an alternative.

Some of the notebooks from the Buildsys 2019 paper don't require Dataport, right? We could probably link to those more explicitly too.

PMeira avatar Jan 11 '21 22:01 PMeira

I agree the example should work with the master branch.

Advantage of REDD is the stability: the dataset authors are not breaking the converter.

levaphenyl avatar Jan 12 '21 06:01 levaphenyl