nistats icon indicating copy to clipboard operation
nistats copied to clipboard

Published 20 hours ago • verified publisher icon nilearn

Fix SimpleRegressionResults

Open Gilles86 opened this issue 6 years ago • 5 comments

This fixes https://github.com/nistats/nistats/issues/150

Gilles86 avatar Mar 19 '18 11:03 Gilles86

OK gave it another try.

The bigger point is that SimpleRegressionResults does not have access to X or Y anymore, so you would have to provide that explicitly to get to residuals or predictions.

Maybe SimpleRegressionResults should at least store X?

Gilles86 avatar Dec 07 '18 15:12 Gilles86

This one we will have to fix. No need to submit a new PR necessarily, tell me the command you used to merge master into this.

kchawla-pi avatar Dec 07 '18 19:12 kchawla-pi

  1. I created a new branch from the commit 2cd2f45e "Test files should not be in  commit".
  2. Then i did a git pull --log upstream master.
  3. It created conflicts which I solved (incorrectly it would seem).
  4. Now the tests are not passing.
  5. I haven't made the changes afterwards that you did as part of addressing the review so that may be why it is not passing. Maybe you can do it again. Maybe as a new PR. @GaelVaroquaux Can you help with the Git-Fu?

kchawla-pi avatar Dec 08 '18 17:12 kchawla-pi

What do you think @Gilles86 , this seems like a good candidate for a new PR. You can also focus on completing the other one first before restarting on this if you like. I don't want to intrude if you are doing other stuff. Lemme know.

kchawla-pi avatar Dec 10 '18 09:12 kchawla-pi

Hi @Gilles86 !

We have incorporated all of Nilstats functionality into Nilearn's master and if you are still interested, i would urge you to reopen this PR there.

We are archiving this repo, so it is read-only.

I know this PR has been stalled for a while but I'm hoping to see you on Nilearn!

kchawla-pi avatar Mar 31 '20 16:03 kchawla-pi