minipack icon indicating copy to clipboard operation
minipack copied to clipboard

README Update?

Open verpixelt opened this issue 4 years ago • 4 comments

Hey I just whipped up a quick experiment to see if I get your Gem going with a webpack config. I ran rails newApp --skip-javascript added my webpack config and followed your instructions. The only way I was able to load the main.js file webpack spits out for me was by using <%= javascript_bundle_tag 'main', skip_pipeline: true %> and then add the main.js files to Rails' assets/config/manifest.js file. It took me several tries to get this going. Is this the intended way? Am I doing something wrong? If that's the intended way, would a README edit PR be welcome?

verpixelt avatar Jul 20 '20 10:07 verpixelt

Thanks to send feedback. I haven’t tried the gem with the recent released Rails so it may not work well even when you follow the instruction written in READM, as you say.

nikushi avatar Jul 20 '20 12:07 nikushi

Why did you need to add the main.js file to assets/config/manifest.js?

nikushi avatar Jul 20 '20 12:07 nikushi

This happens if I dont image

verpixelt avatar Jul 20 '20 13:07 verpixelt

I'm using minipack with rails 6.0.3.1 and with webpack. To insert the webpack I say

pack_options = {'data-turbolinks-track': 'reload', skip_pipeline: true}
javascript_bundles_with_chunks_tag(pack_name, pack_options)
styleesheet_bundles_with_chunks_tag(pack_name, pack_options)

which seems to be what you have done. I don't touch either the Asset Pipeline manifest or the Minipack manifest (when things are going well. When not going well they often have clues).

The HTML ends up like this: (but with more entries).

<script src="/javascripts/vendors-application-b-60456616.8e14be0fdbe87f877f11.js" data-turbolinks-track="reload"></script>
...
<link rel="stylesheet" media="screen" href="/stylesheets/../stylesheets/2.8e14be0fdbe87f877f11.css" data-turbolinks-track="reload">
...

Rails demands that js be in public/javascripts, and that css be in public/stylesheets. Perhaps I need to look again at my stylesheet path, it does look odd.

anitagraham avatar Aug 12 '20 06:08 anitagraham