cync_lights icon indicating copy to clipboard operation
cync_lights copied to clipboard

Potential Bug

Open kevomaco opened this issue 2 years ago • 1 comments

I haven't had a chance to work through the logic of the code in full, which is why I'm not making a PR, but on first pass, this looks like a potential bug: https://github.com/nikshriv/cync_lights/blob/main/custom_components/cync_lights/cync_hub.py#L251

Seems like it should be: room.publish_update()

kevomaco avatar Nov 15 '22 22:11 kevomaco

Thanks for finding this bug. I'll incorporate your change in the next update. Fortunately, the effect of this bug is minimal. This line dates room states when the integration initiates. The rooms still get updated as the switches update, so no real impact, but still worth fixing.

nikshriv avatar Nov 16 '22 05:11 nikshriv

This has been updated.

nikshriv avatar Dec 31 '22 06:12 nikshriv