gringotts icon indicating copy to clipboard operation
gringotts copied to clipboard

Deposited amount not handled correctly on INSUFFICIENT_SPACE

Open Dutch-0 opened this issue 8 months ago • 0 comments

This line seems to be incorrect, since amount is simply set to 0, but some funds may have been deposited: https://github.com/nikosgram/gringotts/blob/f7ade10cb7bee162dc4967eeaadca116d921ed71/src/main/java/org/gestern/gringotts/api/impl/VaultConnector.java#L161-L163

I would submit a PR, but what is the correct Vault approach here? Should amount be the actual deposited amount, or the remaining amount (which could not be deposited)? Also is ResponseType.FAILURE correct in this case?

The vault documentation is not really helpful here: http://milkbowl.github.io/VaultAPI/net/milkbowl/vault/economy/EconomyResponse.html#amount http://milkbowl.github.io/VaultAPI/net/milkbowl/vault/economy/EconomyResponse.html#type

Dutch-0 avatar Jun 21 '24 10:06 Dutch-0