Results 606 comments of Niko Matsakis

One example: It would be nice if IntoIterator were defined as ``` trait IntoIterator { final type Item = Self::Iter::Item; type Iter: Iterator; fn into_iter(self) -> Self::Iter; } ```

I consider the RFC well-motivated: from conversations with people learning Rust, match ergonomics has generally been a success, but it definitely has nasty edge cases around Copy types (and I...

I think we should definitely incorporate the text for now.

> @compiler-errors [doc.rust-lang.org/reference/behavior-considered-undefined.html](https://doc.rust-lang.org/reference/behavior-considered-undefined.html) already mentions invalid metadata in any kind of pointer makes an invalid value, so I don't think we need to add anything on top of that? >...

Hmm, OK, that's not what I thought the consensus was. =) Maybe I'm misremembering, though when I read the text I quoted it seems clear-ish. We need to find some...

OK, so I re-read https://github.com/rust-lang/rust/issues/101336 and in particular found [this comment](https://github.com/rust-lang/rust/issues/101336#issuecomment-1251216579) which was asking whether the validity invariant for vtables was a "decision" or just a "strong recommendation". I guess...

Wearing lang-team hat: +1 EDIT: Well, +1 to the substance, I have some concerns lingering in comments actually that I would like to see resolved. Specifically the `as` point.