Niko Matsakis
Niko Matsakis
On the topic of stabilization phases: I think we can separate that discussion out. I do believe it would be useful for us to distinguish *stabilized* from *recommended for use*,...
@calebcartwright I feel like we should have a short discussion about the ideal process in a lang-team design meeting or some other similar forum, rather than on this PR =)
@rfcbot concern summarize-concerns I'm finding the back-and-forth here a bit confusing, but I'd definitely like to see the stabilization report extended to discuss (a) potential interactions with destructuring assignment and...
> There is one known problem with this approach, relating to the lifetime of temporaries storing expr in the big implicit return expression it produces https://github.com/rust-lang/rust/issues/93951, but it does have...
Quick note on formatting: I just encountered a case with a really long expression being matched. My usual rule was not very satisfactory: ```rust let Some((fooooooo, baaaaaaaaaaaaaaaaaaaar, baaaaaaaaaaaaaaaaaaaaaaaaaaaz)) = something_that_creates_that()...
@rfcbot resolve summarize-concerns Thanks for the edits to the report, everyone, and to @pnkfelix for filing a more precise concern about temporary rvalues.
> re your point on putting `else` onto a separate line, there has been a [similar](https://github.com/rust-lang/rustfmt/issues/4914#issuecomment-887104615) suggestion in the dedicated rustfmt thread I'll move any further replies there =)
@dingxiangfei2009, @pnkfelix, and I got together to discuss alternatives around adjusting the desugaring. We concluded that there is no way to represent the desired temporary lifetimes if we desugar let-else...
Brief update: @dingxiangfei2009 and I have been working on a refactoring to fix the temporary scope issues [as discussed here](https://github.com/rust-lang/rust/pull/93628#issuecomment-1125066530). Progress is being made! Still working on it, though.
One thing I considered: multiple lints for different size thresholds? Probably not so nice.