Nikolas Zimmermann

Results 24 comments of Nikolas Zimmermann

NOTE: RenderLayer doesn't use the optimized "applyTopLeftLocationOffset" anymore, which inlined the most common case, that doesn't involve any coordinate flipping (it used to fallback to the non-inlined "slow path" if...

Done. Will squash the commits before merging -- I meant to ease the reviewing process with small atomic patches.

Rebased once again :-) I hope @smfr finds some time to check it -- I left individual commits and did not squash to ease the reviewing.

Sorry for not responding at all - I'm pretty busy these days...

Heh, the -expected.html files of the new files did not enable LBSE. Sub-pixel alignment for outermost is only correctly implemented for LBSE, legacy rounded to integral points.

> Heh, the -expected.html files of the new files did not enable LBSE. Sub-pixel alignment for outermost is only correctly implemented for LBSE, legacy rounded to integral points. Fixed in...

@smfr would be great if you could have a look - tried several approaches, this was the one which is least intrusive and does what we want for SVG.

I heard that Simon is out of office, @smfr I'll land it now to move on, if you have any comments later on, happy to address them when you return.

What about the svg/text/... testcase in Blink which motivated the fix? Would be good to have another dedicated test to verify the behavior.