notify icon indicating copy to clipboard operation
notify copied to clipboard

feat(service): add lark service

Open immanuelhume opened this issue 2 years ago • 2 comments

Description

Adds a notifier service for Lark.

Motivation and Context

This addresses https://github.com/nikoksr/notify/issues/268.

Lark has three kinds of bots, referred to as "webhook", "custom app", and "store app" bots. The first two are supported through this PR, which explains the two different files webhook.go and custom_app.go. The store apps have a tricky API which would work against the simple style of this library so they are not included here.

How Has This Been Tested?

Basic unit tests using mocks have been written. Manual testing has also been performed.

Screenshots / Output (if appropriate):

The first screenshot is with a webhook. The second is with a custom app.

photo_2022-06-05_23-38-53 photo_2022-06-05_23-39-51

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation (no code change)
  • [ ] Refactor (refactoring production code)
  • [ ] Other

Checklist:

  • [x] My code follows the code style of this project.
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

immanuelhume avatar Jun 05 '22 15:06 immanuelhume

@immanuelhume so sorry for the very late response.

I fixed the compatibility issues with the main branch and some linter warnings. Please check those before you push next time, please.

I greatly appreciate your patience and contribution!

nikoksr avatar Aug 04 '22 15:08 nikoksr

@nikoksr Sorry I must've missed those warnings. Thanks for maintaining this project!

immanuelhume avatar Aug 04 '22 16:08 immanuelhume