Nikodemus Siivola
Nikodemus Siivola
Missing bits in addition to the blink missing: - env 3 & 4 aren't available as patch source shortcuts yet - didn't test how the regular menu access to them...
Superseded by https://github.com/SynthstromAudible/DelugeFirmware/pull/3118/files
Thinking about this, for consistancy _all_ menu-like interactions should wrap around, no? Currently songs, do, but not much else.
So of course this "inconsistency" also applies to Deluge Mix and Deluge Output sources - in which case looper and sampler seem to actually monitor the input instead. For the...
(On current community loadfw of this fails due to the UB issue, but rebasing on top of eg 8e43e8809d730cef7f907e0f92dffdcba5e29d3c works.)
I get a note-on click with these settings even without the kick, unless I drone the note, though. The sidechain clicks are very clear though. https://modwiggler.com/forum/viewtopic.php?t=231354 has some related discussion....
Just confirming that I'm fine with the maintainer change. I have very little bandwidth atm, but if @swapneils submits a PR with appropriate pointers to his current repo, I'll be...
I'll take a look in next week, but I'm guessing duplicated logic somewhere.
Yeah, the change I did was for things driven from `Submenu::drawSubmenuItemsForOled`, this seems to be driven from `ContextMenu::renderOLED`. EDIT: Nope, not ContextMenu but Browser.
So, both context menus and browsers do this. Fixing the browser reliably looks hairy: I think that might better wait for browser refactoring or replacement -- the logic there isn't...