html2canvas icon indicating copy to clipboard operation
html2canvas copied to clipboard

fix: Operation is insecure on safari (#2688)

Open HitenChawda46 opened this issue 3 years ago • 8 comments

Fixes : Operation is insecure on safari Problem : Using background image causes the issue ( note: it can have data uri or image binded to it which is not a concern) Solution : When we use background image , resizeImage function returns an image to create pattern on canvas, however createPattern method does not work properly with images (especially when it's svg ) , so to resolve this we can pass canvas to the createPattern, which means resizeImage always needs to return a canvas on which the required image is drawn already !

Fixes Issue : #2688

HitenChawda46 avatar Jul 02 '22 23:07 HitenChawda46

When is this going to be merged and available ?

emch31Cyto avatar Aug 04 '22 11:08 emch31Cyto

Bump

aleh-skrypko avatar Dec 05 '22 10:12 aleh-skrypko

Bump

ptakizawa-daitan avatar Dec 20 '22 15:12 ptakizawa-daitan

when will this PR merge?

superman566 avatar Aug 17 '23 19:08 superman566

We're using a fork of this in production. What is blocking this from being merged? I would be glad to simplify our build process ;)

zbyte64 avatar Aug 22 '23 16:08 zbyte64

Hi @zbyte64 and others, I am unsure whats taking time. The contribution instruction states to send PR to develop branch, and I don't see one so I've sent it to master, and ofcourse I don't have write access here, so can't merge the PR.

HitenChawda46 avatar Aug 24 '23 18:08 HitenChawda46

Can be tested in @cantoo/html2canvas

Sharcoux avatar Aug 31 '23 02:08 Sharcoux