Niklas Mohrin

Results 120 comments of Niklas Mohrin

(this is currently waiting until #212 is done to make a design choice here)

If you say you have a strong opinion about this, I can live with it, although my opinion isn't changed. Here is how I see it: --- Firstly, I can...

@emhagman We will gladly take your contribution! :rocket:

I must admit, I am not comfortable with `cargo-ndk`, this just adds too much code to maintain to this repository. In #274, I noted that there is the possibility of...

You can choose any of the rust targets (for example [this list](https://github.com/niklasmohrin/clircle/blob/main/.github/workflows/ci.yml#L36)), we would probably be most interested in `aarch64-linux-android` and friends. If I understand it correctly, cross uses a...

A PR for this should also add a job to github actions that makes sure the build still works for android; I am not sure whether we can test in...

I wouldn't consider this issue done until we build in CI, it shouldn't be difficult (see [my comment in the other PR](https://github.com/dbrgn/tealdeer/pull/274#discussion_r897300717)). I don't think we need to run tests...

We could also consider just unpacking the tldr repo directly into the `TEALDEER_CACHE_DIR`. This is only an option, if we don't need to put anything else in the cache, but...

Interesting :thinking: Implementing this will need some work, because we currently don't distinguish between the different "kinds of empty lines". You would somehow need to communicate this between `line_iterator.rs` and...

This could also be considered when running with the `--seed-config` flag to specify where to put the generated file. I think the option should then have a more verbose name...