python-chess icon indicating copy to clipboard operation
python-chess copied to clipboard

Update to have Stockfish 17 Win-Draw-Loss Model

Open MX6464 opened this issue 1 year ago • 4 comments

Can anyone add the new Stockfish 17 Win-Draw-Loss model? https://github.com/official-stockfish/WDL_model

MX6464 avatar Sep 23 '24 16:09 MX6464

Looks like this time it's not just updating the parameters (official-stockfish/Stockfish@2054add23cf234f302c67709efc0d265c5a98eae), but also taking into account material counts: official-stockfish/Stockfish@9b92ada935ddf920491156be22f609afaca4d840.

niklasf avatar Sep 27 '24 15:09 niklasf

That is correct. What does/did python-chess use SF's wdl model for?

robertnurnberg avatar Sep 27 '24 15:09 robertnurnberg

python-chess WDL calculations found here: https://github.com/niklasf/python-chess/blob/5826ef5dd1c463654d2479408a7ddf56a91603d6/chess/engine.py#L446-L588

MX6464 avatar Sep 27 '24 16:09 MX6464

Ok, so this needs to be based on material count now, so quite an invasive change. Also NormalizeToPawnValue needs to be replaced by a now.

Edit: And the capping to [-4000,4000] can go.

robertnurnberg avatar Sep 27 '24 16:09 robertnurnberg