Niklas Fiekas
Niklas Fiekas
Cool, I like the approach. Some questions for clarification: 1. Assuming allocation succeeds, is `lv_cache_get()` guaranteed to always make space for the latest item? The current `lv_cache` has a mechanism...
Tried to implement this in #6362.
With `evil: Evil` as defined above: ```rust let key = evil.as_ref().as_ptr(); // Pointer to "hi" let key_len = evil.as_ref().len(); // Length of "there" ``` Then, passing `key` with `key_len` to...
The FFI functions are unsafe, because the compiler cannot check the required invariants, but this library tries to offer a safe interface. So it needs to maintain all required invariants....
For example, yes. And one of Rusts main selling points is to encode such requirements in the type system, so that they can be checked at compile time. In most...
Sure. I have completed the example from the PR description and added it as a test case. ``` rust-rocksdb git/evil-as-ref 6s ❯ git revert HEAD [evil-as-ref 548bb16] Revert "Fix unsoundness...
Fwiw, the width and height of `cg-container` are [based on](https://github.com/lichess-org/chessground/blob/b58a1d082a2ce75739da60d57780b4a982980a84/src/render.ts#L185) the *width* given to `cg-wrap`.
Generally such long timeouts for shutdown are not acceptable, so instead the default `KillSignal=SIGTERM` is used. This will cause a somewhat graceful shutdown, i.e., work won't be completed, but the...
Ah, interesting. I didn't realize how nicely your snippet works: So it's immediate SIGINT, *SIGTERM* after the timeout, and then eventually SIGKILL if something went wrong?
Unfortunately I don't know a clean way. It's possible to call `sf.terminate()` given `sf` is an instance, but it does not work reliably: https://github.com/lichess-org/lila/blob/5d26cf97458fa3772d21dee65a61d217058e617b/ui/ceval/src/worker.ts#L204-L206