feelin icon indicating copy to clipboard operation
feelin copied to clipboard

feat: implement round functions

Open Skaiir opened this issue 1 year ago • 1 comments

Which issue does this PR address?

Closes #40

Skaiir avatar Aug 08 '24 07:08 Skaiir

Putting this one back in draft because of some failing TCK tests. Basically when the scale gets too big the math we use to calculate things lead to some 1e^toomuch. Need to work on a smarter way to handle this.

Skaiir avatar Aug 08 '24 15:08 Skaiir

Hi @nikku , just want to check is there any plan to merging this feature?

harmoney-ryanli avatar Oct 05 '25 19:10 harmoney-ryanli

@harmoney-ryanli My last information is that some TCK tests are failing. I've looked into the failures and they are honestly edge cases. I've added additional test cases for larger fractional values and will merge this contribution.

Thanks @Skaiir :star:

nikku avatar Oct 05 '25 21:10 nikku

Released as v4.5.0.

nikku avatar Oct 05 '25 21:10 nikku