didi
didi copied to clipboard
14 destructured objects
WIP Closes #14
Thanks for your PR. As I've commented I think this is something worth supporting if the bundle size increase is manageable.
However, I'd ask you do a couple of things:
- Do not separate existing and new tests (what is the benefit)?
- Clearly and thoroughly test different cases
- Semantics of mixed
$injectand destructuring logic - Nested destructuring
- Semantics of mixed
- Cover default values
- Do not mix general documentation improvements and object destructuring
- Works for all standard destructuring cases (including newlines, default values, argument renaming). I believe without that the implementation is too fragile to be merged.
Closing due to inactivity.