didi icon indicating copy to clipboard operation
didi copied to clipboard

14 destructured objects

Open basejump opened this issue 3 years ago • 1 comments

WIP Closes #14

basejump avatar May 28 '22 16:05 basejump

Thanks for your PR. As I've commented I think this is something worth supporting if the bundle size increase is manageable.


However, I'd ask you do a couple of things:

  • Do not separate existing and new tests (what is the benefit)?
  • Clearly and thoroughly test different cases
    • Semantics of mixed $inject and destructuring logic
    • Nested destructuring
  • Cover default values
  • Do not mix general documentation improvements and object destructuring
  • Works for all standard destructuring cases (including newlines, default values, argument renaming). I believe without that the implementation is too fragile to be merged.

nikku avatar Jun 06 '22 15:06 nikku

Closing due to inactivity.

nikku avatar Nov 22 '23 10:11 nikku