Nico Rehwaldt

Results 1471 comments of Nico Rehwaldt

Upstream fixes most described isses: https://github.com/bpmn-io/diagram-js/pull/932. Try out the changes via ``` npx @bpmn-io/sr bpmn-io/bpmn-js#use-search ``` CC @lmbateman

Previous observations, addressed by this PR as well as https://github.com/bpmn-io/diagram-js/pull/932: --- Some observations: * The search syntax and what is required by `search-pad` are incompatible, and require [manual conversion](https://github.com/bpmn-io/bpmn-js/compare/use-search?expand=1#diff-8a394357d479589cd4606da39fc67ac8ed374cc2803e5483f508239a88194ee9R72). This...

@sovanmishra Thanks for your bump on this issue. If you are a Camunda Enterprise user, please file this issue as a support ticket, too.

I investigated this locally and can reproduce the issue. In isolation the tests run just fine: ![image](https://github.com/bpmn-io/diagram-js/assets/58601/022b7a5d-35d1-4154-ac42-7f2015f8e3a9) Work in progress draft PR up at https://github.com/bpmn-io/diagram-js/pull/922.

Cf. https://github.com/bpmn-io/diagram-js/pull/922#issuecomment-2386279060

Released as [[email protected]](https://github.com/bpmn-io/diagram-js/releases/tag/v14.11.0).

Example integration surfaced some issues that we may want to follow-up on: https://github.com/bpmn-io/bpmn-js/pull/2235.

Additional finding, debugging the implementation: We do no longer tokenize between spaces, this makes it impossible to match two works, [such as this](https://demo.bpmn.io/s/start): ![image](https://github.com/user-attachments/assets/92c575ab-10d7-4177-b49f-7020c23f3665)

Fun fact: We removed a spec that verified fuzzy search. I restored it via https://github.com/bpmn-io/diagram-js/pull/932/commits/ebbe69c0e52be38b98ea1746f03015614d6ea209. This PR is now ready to be picked up in order to re-integrate the search...

Cf. https://github.com/bpmn-io/bpmn-js/pull/2235#issuecomment-2405523858. I'll give you an E2E demo once I'm done with implementing the search, unless you want a demo earlier, to discuss what we do (did), and why.