Nikitha Chettiar
Nikitha Chettiar
> The sonar cloud comments have been resolved.
> thanks for making most of the changes. Could you also please: > > * add a changelog entry > * put together a PR on the kiota-samples repo to...
> Thanks for making the changes. I still believe we're missing an aspect: properties that are complex types or collections of complex types. if an event has a start date...
The issue can addressed separately and not necessarily in this PR. The current PR works fine at runtime for the Graph v1 generation. Also, the issue is not introduced in...
> Unless I missed something I don't believe properties that are complex types or collections of complex types are handled yet. If they are, can you also update the samples...
> Thanks for sharing that, I still think it should be done at the constructor level instead so we don't loose things like backing story dirty tracking on the properties...
> why does the model expect a class instance? the generic type constraint only specifies parsable. https://github.com/microsoft/kiota-typescript/blob/91a90e3a71e0dfe93386ddb2c1e1ff540e9c9f1e/packages/abstractions/src/serialization/serializationWriter.ts#L91 > > The other affectation case you've shared is valid, I didn't think...
> > why does the model expect a class instance? the generic type constraint only specifies parsable. https://github.com/microsoft/kiota-typescript/blob/91a90e3a71e0dfe93386ddb2c1e1ff540e9c9f1e/packages/abstractions/src/serialization/serializationWriter.ts#L91 > > The other affectation case you've shared is valid, I didn't...
Added model instantiation at the setter level
> Thanks for making the updates. I'm not sure why we have this block? https://github.com/microsoft/kiota-samples/pull/776/files/e21410bd705c5b182669b6e006693cd6821c6740..17dc949f99bfffc39fa4df1c99d36f8cfbe436ac#diff-06d4b04f846a062595d3f4c5a08d612f6e15d590a38991b97a1a0e4d151e40eaR74 Which block are you referring to? > And why is additional data nullable now? https://github.com/microsoft/kiota-samples/pull/776/files/e21410bd705c5b182669b6e006693cd6821c6740..17dc949f99bfffc39fa4df1c99d36f8cfbe436ac#diff-06d4b04f846a062595d3f4c5a08d612f6e15d590a38991b97a1a0e4d151e40eaR9...