stompest icon indicating copy to clipboard operation
stompest copied to clipboard

PEP 492 - Rename async

Open nitrag opened this issue 6 years ago • 5 comments

This will rename all module references of async to twisted to be compatible with Python 3.7+.

I ran the tests but I think the SSL ones failed. Please run your own tests before merging.

Resolves https://github.com/nikipore/stompest/issues/46

nitrag avatar Oct 22 '18 15:10 nitrag

@nikipore Is this what you were looking for in a PR?

nitrag avatar Oct 22 '18 15:10 nitrag

Yes it is, thank you.

I am way too busy right now (job and kids), plus I am going to be on vacation, so a proper test and package before end-of-year might be a problem. This is a backwards-incompatible change, so I am going to bump the release to 2.4.

Time that someone else takes over this project, it has no longer relevance for my daily work, although I am still at the same company (but have moved on to other missions and no longer program myself on the job).

nikipore avatar Oct 25 '18 09:10 nikipore

@nikipore were you able to get sometime to merge this request? Seems good to me

wazirsoft avatar Feb 15 '19 16:02 wazirsoft

I'm also interested in getting this to work, STOMP libraries for Python are kinda scarce.

abompard avatar Feb 22 '19 10:02 abompard

Sorry guys, I am entirely immersed in job and family. Don't know when or whether I'll find the time to adopt this.

Problem is, I've got to set up everything from scratch, and this will be a breaking change, meaning that I will probably have to deprecate the PyPI package stomp.async and create a new one stomp.twisted.

Still no-one interested in taking over and starting a new fork? I'd be willing to pass the control of the PyPI packages. This is how I got hooked by @theduderog years ago ...

nikipore avatar Feb 22 '19 21:02 nikipore