PHP-Parser icon indicating copy to clipboard operation
PHP-Parser copied to clipboard

Add option to disable recursive refs in Name Resolution

Open dhaeckel opened this issue 10 months ago • 3 comments

dhaeckel avatar Mar 11 '25 13:03 dhaeckel

Hm, I wonder if we should just always do the clone if replaceNodes is disabled, rather than introduce an additional option.

nikic avatar May 31 '25 10:05 nikic

Happy to change the PR accordingly, although @theofidry raised the concern of higher memory consumption in this case. This would impact all apps that use replaceNodes = false. I can't really tell, if this is a problematic impact or negligible. I'll leave it up to you, which way you prefer.

dhaeckel avatar Jun 03 '25 13:06 dhaeckel

Hi @nikic,

do you have any opinion on how to go forward with this? I'm happy with any of the two solutions.

dhaeckel avatar Sep 10 '25 20:09 dhaeckel