FastRoute icon indicating copy to clipboard operation
FastRoute copied to clipboard
verified publisher icon nikic

Update workflows

Open codemasher opened this issue 1 year ago • 2 comments

Hey,

this PR updates the workflow runs to use the latest versions of actions/checkout and ramsey/composer-install to stop the node.js deprecation warnings.

Further I have moved the PHPUnit cache directory under .build/.phpunit.cache (now looking at it, the leading . is a bit unnecessary) and cleaned up the .gitignore.

Cheers!

codemasher avatar Apr 21 '24 22:04 codemasher

Thanks for the patch.

What's the benefit in changing the phpunit cache location to you?

lcobucci avatar Apr 23 '24 06:04 lcobucci

This is a standard practice in all my projects

  • no random unrelated directories in the project root, the other (temporary) PHPUnit output paths (coverage, logs) are already in .build
  • easy to .gitignore anything not project related
  • only have to exclude only a single directory in the IDE (other than vendor)

Actually, we could do the same with the .phpbench directory, but i haven't looked at where it is created, nor ran it locally yet.

codemasher avatar Apr 23 '24 07:04 codemasher

@codemasher I've rebased this branch on top of the latest changes, keeping only the changes that make sense to me.

Thank you for contributing!

lcobucci avatar Jun 18 '25 20:06 lcobucci