ngx-international-phone-number icon indicating copy to clipboard operation
ngx-international-phone-number copied to clipboard

fix: missing country flag

Open mikiol60 opened this issue 4 years ago • 6 comments

Resolves this issue where country flag is missing due to broken image link.

It's recommended to hold your assets internally within your package as much as possible

mikiol60 avatar Aug 24 '20 20:08 mikiol60

@mikiol60 can please help me with CSS files like where should i put that flag.png and also can i have that file as i tried but i am not able to get success

Coder-Himanshu avatar Aug 27 '20 04:08 Coder-Himanshu

Here is the link to the image. @Coder-Himanshu

https://user-images.githubusercontent.com/20545357/90998272-b5b86280-e591-11ea-992b-c422d78070e2.jpg

Download it and put it anywhere you want. Then head to your app.component.css/scss and add something like

:host ::ng-deep .flag {
  background-image: url('../assets/image/flags.jpg') !important;
}

mikiol60 avatar Aug 27 '20 05:08 mikiol60

Hi @mikiol60 i have placed image inside images folder and copy mentioned css in app.component.css still getting issue.

Please find below image for your reference.

image

Coder-Himanshu avatar Aug 27 '20 08:08 Coder-Himanshu

@Coder-Himanshu The fix i mentioned is not supposed to remove that error. The error likely will be there but the flag images should visible though. (That error will be removed only after the PR I provided is merged)

mikiolGLP avatar Aug 27 '20 08:08 mikiolGLP

Ok is there any solution to resolve this ? or any other package ?

Coder-Himanshu avatar Aug 27 '20 08:08 Coder-Himanshu

Try this as an option.

mikiol60 avatar Aug 27 '20 08:08 mikiol60