docblockr icon indicating copy to clipboard operation
docblockr copied to clipboard

Enhancement: Add support to remove/undo multiline comment blocks

Open YenHub opened this issue 5 years ago • 2 comments

First, thank you for developing such a super awesome tool - it's genuinely superb!

Forgive me if I've missed anything; I have searched through the documentation and was unable to find any reference to undoing multiline comment blocks generated by docblockr.

It would be super helpful if the comment/uncomment keymap was bound also to multiline comment blocks, allowing you to uncomment when using "Ctrl" (CMD) + "/" to uncomment.

/****************************
#moreWrap {                 *
    position: absolute;     *
    top: 0;                 *
    right: 0;               *
    height: 30px;           *
    line-height: 50px;      *
    width: 30px;            *
    overflow: hidden;       *
    text-indent: 100%;      *
    color: transparent;     *
    white-space: nowrap;    *
    z-index: 3;             *
    cursor:pointer;         *
    padding:2px 2px 0px 0px *
}                           *
 ****************************/

Hopefully I will get some time over the weekend to take a look at forking and trying to make the changes required to generate a pull request.

Before doing so, I thought it sensible to ask about this feature first and also whether you have any suggestions that could help me on my journey making the changes for a pull!

Thanks Nikhil, loving your moves!

YenHub avatar May 01 '19 08:05 YenHub

Hi @YenHub, appreciating your enthusiasm! I think I should tell you though that this package isn't really actively maintained anymore. @nikhilkalige isn't doing anything on it anymore and I took over maintenance at some point. But at the moment I don't have much time of it anymore either. However if you submit a PR thats ready to go, I'll try to take a look at it and merge it. That's probably not what you wanted to hear – sorry.

That being said, there is a way to "overload" commands by creating a new command with the same keybinding and then in case you want to "fall through" to the original command calling event.abortKeyBinding(). If you still want to give it a go, I recommend following this approach.

MoritzKn avatar May 01 '19 20:05 MoritzKn

Hi @MoritzKn,

Thanks for your swift response and kindly providing me with a route to follow!

I'll fork the repo over the weekend and take a deep dive to see whether I am able to produce a clean and robust solution that can deliver this functionality.

Once complete, I'll create a PR and get this over and I'll leave this issue open to document the outcome.

Again, thanks kindly for your return, super helpful!

@YenHub

YenHub avatar May 03 '19 09:05 YenHub