docker-py-revanced Use a browser to load the page

Use a browser to load the page

Open IMXEren opened this issue 10 months ago • 4 comments

Let me know what you think about this...

Fixes #375

There is a possible disadvantage for local docker users, i.e. the uncompressed size is 3x times (1.47 GB) of the current image (500 MB). I suppose offerring this feature as another tag can be a good option.

Mar 30 '24 23:03 IMXEren

Thanks a lot for the PR. I always wanted to add this support but never got the time to learn and implement.

I'll review it as soon as possible.

Mar 31 '24 21:03 nikhilbadyal

Pretty big PR. I'm unfamiliar with the headless browser too. So, I'm not sure I'll be able to maintain, in case any issue occurs. I'll mark the PR as draft for now. Unless i get confident that I can maintain it myself.

Plus docker image size difference is huge.

Apr 02 '24 09:04 nikhilbadyal

It's alright.

Apr 02 '24 12:04 IMXEren