belle icon indicating copy to clipboard operation
belle copied to clipboard

Incompatible with React v16.0.0.

Open eddiekollar opened this issue 7 years ago • 6 comments

Similar error message as in #330 : Module not found: Can't resolve 'react-dom/lib/CSSPropertyOperations'

eddiekollar avatar Oct 06 '17 21:10 eddiekollar

Back then we could solved it by moving the import, but at this point functionality must be extracted from the React repo.

@eddiekollar Are you interested to do that? Here is the file: https://github.com/facebook/react/blob/2566b2420b714c00b3a456b8d744a26387eaf511/src/renderers/dom/shared/CSSPropertyOperations.js All the required imports would also be need to be pulled in

nikgraf avatar Oct 10 '17 21:10 nikgraf

@nikgraf Yes, I would be happy to.

eddiekollar avatar Oct 13 '17 16:10 eddiekollar

@eddiekollar awesome, looking forward to your PR :)

btw another alternative would be to switch to styled-components for example. Either way if fine for me. Happy to accept PRs :)

nikgraf avatar Oct 16 '17 13:10 nikgraf

@nikgraf I started working on switching to styled-components.Here is my fork https://github.com/frontmaker/belle. Will be glad for any help or advices.

frontmaker avatar Dec 04 '17 20:12 frontmaker

Guys, is there any update on compatibility of latest React version? Is there a workaround without downgrading React?

shahabhinandan avatar Jul 25 '18 09:07 shahabhinandan

fuck

testacode avatar Jun 30 '19 05:06 testacode