edotor.net icon indicating copy to clipboard operation
edotor.net copied to clipboard

Some BGCOLOR's don't work in Edotor

Open ghost opened this issue 3 years ago • 2 comments

Stumbled upon this while reviewing a pull request from another repo:

It appears not all BGCOLOR values work in Edotor, the following always show as black as shown in this example

  • DARKRED
  • FUCHSIA
  • REBECCAPURPLE
  • DARKMAGENTA
  • LIME
  • LIGHTGREEN
  • OLIVE
  • DARKCYAN
  • TEAL
  • AQUA
  • DARKBLUE
  • SILVER
  • DARKGRAY

Another web editor shows these colours without a problem.

ghost avatar May 04 '22 15:05 ghost

Now fixed in core library: https://github.com/nikeee/dot-language-support/commit/c724aac41053a05dc824b78215c545c4b24fcab0

Porting this over to edotor.

nikeee avatar May 04 '22 19:05 nikeee

This is just for the auto completion, though. It seems that they were added in a newer version of GraphViz.

We're using a divverent rendering library than the site you linked (they use D3, edotor uses viz.js, which is the actual Graphviz).

It it likely that we need a new build of viz.js for this to work: https://github.com/mdaines/viz.js

Working on it.

nikeee avatar May 04 '22 19:05 nikeee