Nik Everett

Results 106 comments of Nik Everett

For folks playing along - we're pretty sure we're going to reduce the memory usage here. That's not the thing holding this up. The real question is "why didn't the...

> I might be wrong, but these are the main reason that I found so far that BytesRefBlockBuilder doesn't adjust circuit breaker size properly. `BytesRefBlockBuilder` is indeed pretty special here....

> `java.lang.ArithmeticException: long overflow` I imagine this is possible for any version. You do have to stick a far future date though. I don't think a blocker but would be...

The failing case is: `+292278829-09-20T01:30:20.154Z` + `P769Y9M15D`. That's the `year two hundred ninety two million, two hundred seventy eight thousand, eight hundred twenty nine` plus `seven hundred sixty nine` -...

I think this should replace #85185.

Sleeping on this the abstraction feels a little over designed - maybe premature. Maybe not because @romseygeek seemed to think it made sense with his plans. And it feels like...

> Sorry for my own drive-by comment, I found the logic in the last PR (#85185) a lot more focused and easy to understand. Would it make sense to start...

I wrote up a guide to making new functions about six months ago that's gone stale. I'll try and build another guide for it on Monday.

Here are some instructions for adding functions.