ifrnet-ncnn-vulkan icon indicating copy to clipboard operation
ifrnet-ncnn-vulkan copied to clipboard

Timestep arg does not do anything

Open n00mkrad opened this issue 3 years ago • 5 comments

Same issue as in rife-ncnn-vulkan.

Changing timestep argument does not have any effect.

n00mkrad avatar Jul 20 '22 23:07 n00mkrad

Vimeo90K models can only do 0.5 timestamp interpolation.

GoPro models can do arbitrary timestamp interpolation.

nihui avatar Jul 21 '22 06:07 nihui

it works - the GoPro models are not as impressive like Vimeo ones.

Thank sooooooo much for sharing Your great work * It works fantastic on Mac OSX!

Hudaldadi avatar Jul 21 '22 08:07 Hudaldadi

Vimeo90K models can only do 0.5 timestamp interpolation.

GoPro models can do arbitrary timestamp interpolation.

I know, but the -s argument does not work, even when using the GoPro models. -s 0.25 will do 2x interpolation instead of 4x.

n00mkrad avatar Jul 21 '22 13:07 n00mkrad

maybe the -s argument is only choosing the position in time and does not generate more frames.

Hudaldadi avatar Jul 21 '22 16:07 Hudaldadi

No, the code is just broken. When processing an entire directory, it always uses numframes / the count of files to control this. You need to specify how many frames you want and it should work. OTOH when only passing in single files only the timestep argument does anything. As clear as the -tta flag that all the upscalers provide with no documentation which sometimes lowers quality.

NeedsMoar avatar Nov 25 '23 02:11 NeedsMoar