Nils Goroll
Nils Goroll
This has been discussed during bugwash. We understand the need for the feature, but we think that it should be implemented as a CLI command rather than in VCL. @carlosabalde,...
I am going to take this ticket hostage for planning the _tell_ interface. notes from pow-wow discussion: * Only warm vcls can be told * vmod objects can have ears...
Your efforts are appreciated, thank you! @ehocdet, do you intend this as a poc to give the issue some traction or do you actually want to work towards code fit...
On a related question: Shouldn't callers of `VRE_capture()` be given a way to query how many capture groups are required?
Another related question: Or should `VRE_compile()` offer a way to specify "no more than X capture groups"?
> If the caller doesn't want to capture more than N groups, well then don't. The point is to fail the _compilation_ if the pattern contains more than N groups,...
After the last comment from @Dridi I have now added a compile time check for a maximum of 9 capture groups: As explained by @Dridi , we have no facility...
@slimhazard yes, this is a breaking change, thus the tip in the error message
Related: Working on [a recent addition to the re vmod](https://gitlab.com/uplex/varnish/libvmod-re/-/merge_requests/3), the question arose [if the VRE API could be changed to allow this use case](https://gitlab.com/uplex/varnish/libvmod-re/-/merge_requests/3#note_1156193135). Unless I overlook something, in...
I forgot: I recommend to only look at the first commit https://github.com/varnishcache/varnish-cache/pull/3515/commits/f2747392243c75ed668a257642c870a2770f9435 The other changes have been scripted using coccinelle.