Nils Goroll comments

Results 592 comments of


                                            Nils Goroll

Stash objcore references until the end of the task to avoid copies

> but what kind of a pointer do you think for return (synth(200, some_vmod.some_string())); the vmod would return? To be very clear: I think the raised concern is without substance.

Stash objcore references until the end of the task to avoid copies

@dridi because you requested changes on, I think, an unfounded basis, I would appreciate an update from your end.

Stash objcore references until the end of the task to avoid copies

@dridi ?

Stash objcore references until the end of the task to avoid copies

*VERY* good find by @bsdphk : `vcl_miss` gets called with an optional `stale_oc`, which we need to treat equally. Edit: this is addressed in 4f37d4cdb07f6be8cb3a20e6620c1d9d6a559ea6 Also we should consider creating...

cache_vcl: Do the temperature dance for backend creation races

Sorry, if anyone was real quick they might have caught a little glitch. I force-pushed a correction.

cache_vcl: Do the temperature dance for backend creation races

bugwash: leave more elaborate explanation on the race here

cache_vcl: Do the temperature dance for backend creation races

@bsdphk as promised, the more elaborate explanation of the race: https://github.com/varnishcache/varnish-cache/blob/305be79c8bc2bab4abb30a9c167c2d5bb35144ce/bin/varnishd/cache/cache_vcl.c#L632-L634 when, after this point, `VRT_AddDirector()` gets called from another thread, the new director is added to the director list...