django-easy-pdf

django-easy-pdf copied to clipboard

Support loading of external resources

2

As documented, this library does only support loading of local resources in fetch_resources. I would like it to support loading of resources from an external URL. My use-case is loading...

anderspetersson

Add support for non-local resources

2

Now supports HTML URIs with relative protocol (starts with `//example.com/image.png`), http:// and https://. This PR would resolve #7.

maestrofjp

Does not support Sekizai tags

1

The current version does not support templates with Sekizai tags. Would the maintainer accept a PR that wraps the `Context` with `SekizaiContext` if Sekizai is an installed app? Otherwise, if...

maestrofjp

Use staticfiles finders for fetch_resources

2

In my app, the existing implementation of fetch_resources only worked if collectstatic had been run. Using Django's staticfiles.finders.find() is more flexible for different staticfiles configurations.

steinbro

File "C:\Python312\Lib\site-packages\easy_pdf\views.py", line 9, in from .rendering import render_to_pdf_response File "C:\Python312\Lib\site-packages\easy_pdf\rendering.py", line 11, in from django.utils.http import urlquote ImportError: cannot import name 'urlquote' from 'django.utils.http' (C:\Python312\Lib\site-packages\django\utils\http.py). Did you mean: 'unquote'?

simokamaa

from easy_pdf.views import PDFTemplateView File "C:\Python312\Lib\site-packages\easy_pdf\views.py", line 9, in from .rendering import render_to_pdf_response File "C:\Python312\Lib\site-packages\easy_pdf\rendering.py", line 12, in from django.utils.six import BytesIO ModuleNotFoundError: No module named 'django.utils.six'

simokamaa

am just fixing errors, is there no condition especially among code reviewers, or are they just merging

simokamaa