nightwatch icon indicating copy to clipboard operation
nightwatch copied to clipboard

Fixed the issue related to Cucumber Test Suite in browser.end

Open shivansh-bhatnagar18 opened this issue 11 months ago • 3 comments

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • [x] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • [ ] If you're fixing a bug also create an issue if one doesn't exist yet;
  • [ ] If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • [x] Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • [ ] If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • [ ] Do not include changes that are not related to the issue at hand;
  • [x] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • [ ] Always add unit tests - PRs without tests are most of the times ignored. Fixes Issue Number #3332

shivansh-bhatnagar18 avatar Mar 09 '24 06:03 shivansh-bhatnagar18

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 09 '24 06:03 CLAassistant

@shivansh-bhatnagar18 What are you trying to achieve here?

garg3133 avatar Mar 09 '24 12:03 garg3133

@garg3133 The Issue was related to the code snippet ending the test suite before while the Nightwatch still tries to close the session which results in an error. One possible solution was mentioned in the issue #3332, So I implemented that.

shivansh-bhatnagar18 avatar Mar 09 '24 18:03 shivansh-bhatnagar18

Fixed in #4209. Thanks for the PR!

garg3133 avatar May 22 '24 19:05 garg3133