nightwatch
nightwatch copied to clipboard
java not installed error fixed
solve #3105 Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
- [x] Create a new branch from master (e.g.
features/my-new-feature
orissue/123-my-bugfix
); - [x] If you're fixing a bug also create an issue if one doesn't exist yet;
- [x] If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
- [x] Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
- [x] If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
- [x] Do not include changes that are not related to the issue at hand;
- [x] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
- [x] Always add unit tests - PRs without tests are most of the times ignored.
@garg3133 I have tried to solve issue please review it and tell if there is any issue .
@Ritika8081 Thanks, I'll try to review this PR tomorrow.
But, on a quick glance, instead of using additional packages (which btw are already included with Node and don't need to be installed separately) and checking if java -version
command works, you could try to follow where exactly the error is occurring if Java is not installed and then try to catch and modify the error so that it is easier for user to understand.
But, in case that approach doesn't work, testing java -version
also seems a fair (but costly) solution.