nightwatch icon indicating copy to clipboard operation
nightwatch copied to clipboard

Published 20 hours ago • verified publisher icon nightwatchjs

Fix frame() command to support page object element

Open yashPratp983 opened this issue 1 year ago • 5 comments

This PR addresses the issue where the frame() command does not support page object elements.To solve the issue this PR implements frame() command as client-command instead of protocol command.

yashPratp983 avatar Jul 18 '23 18:07 yashPratp983

Status

  • ❌ No modified files found in the types directory. Please make sure to include types for any changes you have made. Thank you!.

github-actions[bot] avatar Jul 18 '23 18:07 github-actions[bot]

We need an additional test with frame() using a page object element.

beatfactor avatar Jul 19 '23 10:07 beatfactor

Thanks @yashPratp983. You could perhaps add a test that looks similar to this for the frame command: https://github.com/nightwatchjs/nightwatch/blob/e7fde68bdf6dd43e9a1c7bcd38263f54dd287bda/test/src/core/testPageObjectCommands.js#L31

gravityvi avatar Jul 19 '23 11:07 gravityvi

I have added the test.

yashPratp983 avatar Jul 24 '23 07:07 yashPratp983

Any updates here?

gravityvi avatar Aug 16 '23 11:08 gravityvi