nightwatch
nightwatch copied to clipboard
check if parentFolder is not a file
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
- [x] Create a new branch from master (e.g.
features/my-new-feature
orissue/123-my-bugfix
); - [x] If you're fixing a bug also create an issue if one doesn't exist yet;
- [x] If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
- [x] Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
- [x] If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
- [x] Do not include changes that are not related to the issue at hand;
- [x] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
- [x] Always add unit tests - PRs without tests are most of the times ignored.
I tried this solution and solved the problem. We need this feature in our projects I hope someone can have a look here and merge it
I just wanted to understand what was the issue this PR fixes? Cc @mostmentor / @AlaaSayed794
When we run on parallel and the tests are passed in src_folder
it was logged overlapped like this
When we run on parallel and the tests are passed in
src_folder
it was logged overlapped like this
If I had understood it correct then to reproduce the issue I have to run tests in parallel, and the same tests are also passed in src_folder
then logging is overlapped?
Thanks for the follow up. Yes. In my case I have to do this because I need to exclude some tests in a way that let me know they are skipped. So I'm filtering all the tests that needs to be run before running and I pass them to the src_folders. I won't be forced to do this if This enhancement is implemented.
But for now I think this solves the bad logging issue. More details on what I get is in the issue attached to the pr. https://github.com/nightwatchjs/nightwatch/issues/3131
@vaibhavsingh97 this has been around for a while now, I still has this logging issue this is what is printed before each test step : anotherTestName.js/realTestName.js
Closing this pull request as there is new PR for this change: https://github.com/nightwatchjs/nightwatch/pull/3539