nightwatch icon indicating copy to clipboard operation
nightwatch copied to clipboard

Published 20 hours ago • verified publisher icon nightwatchjs

Fix: value is redacted in HTTP log in setPassword command

Open vaibhavsingh97 opened this issue 2 years ago • 2 comments

Description: This PR redact password in verbose HTTP logs

Reference:

before: image

after: image

Remaining:

  • need to unset redactParams in HttpRequest

vaibhavsingh97 avatar Jul 21 '21 10:07 vaibhavsingh97

@beatfactor I had made changes according to your suggestion. can you please take a look? I still need to add few tests around it, hence marked the PR as draft

vaibhavsingh97 avatar Jul 29 '21 14:07 vaibhavsingh97

This issue has been automatically marked as stale because it has not had any recent activity. If possible, please retry using the latest Nightwatch version and update the issue with any relevant details. If no further activity occurs, it will be closed. Thank you for your contribution.

stale[bot] avatar Apr 16 '22 15:04 stale[bot]

@vaibhavsingh97 is this PR still required?

harshit-bs avatar May 31 '23 08:05 harshit-bs

We need to support this use case. @vaibhavsingh97 Do you think we can work on this PR to add the feature to Nightwatch v3

gravityvi avatar Jun 02 '23 10:06 gravityvi

Closing this PR. This has been stale for a long time. We can raise a new PR to add this feature.

gravityvi avatar Aug 25 '23 07:08 gravityvi