nightwatch-docs
nightwatch-docs copied to clipboard
nightwatchjs
Dynamically rendering PageNavigators.
Dynamically rendering PageNavigators. With this change, the Next Prev page navigators will be generated dynamically.
Review time on a scale of 1-5 is 3.
@beatfactor Should I update .gitignore then?
it's fine, you can leave it.
@nothuman2718 Try not to force push on the PR every time you make some changes, it makes it hard to assess the improvements you've made after the last review.
For a few pages, the titles that we have in the page navigators are different from the titles we have on the sidebar (on the main website) while they're going to match exactly with this PR.
I think it might be a good idea to keep these titles for page navigators and not match all the page navigator titles with the titles on the sidebar. This would be especially useful when we have situations like below where the "Next Page" such says "Introduction" while it should be something like "Introduction to Mobile Testing".
This could be easily achieved by supplying an alternative title for each page (if applicable) in the navItems list.
@beatfactor What do you think?
think it might be a good idea to keep these titles for page navigators and not match all the page navigator titles with the titles on the sidebar. This would be especially useful when we have situations like below where the "Next Page" such says "Introduction" while it should be something like "Introduction to Mobile Testing".
Sure.