[Feature] Add theatre mode in fullscreen button

[karlito40]

Hello,

I've add a button in the video player to enable the "theatre mode" in fullscreen. I think it could be useful for people. At least it is for me.

Here is a little preview:

I couldn't make a more relevant icon though as i don't have access to illustrator.

[night]

circling back to this now. is it possible to use twitch's theater mode icon, and then only enable this icon when already in fullscreen?

the functionality could be:

1. enter fullscreen
2. enable theater mode, which re-requests full screen with chat
3. clicking theater mode icon again re-requests full screen without chat

what do you think?

[karlito40]

It was my first approach. I think it's the cleanest solution but there is an issue with that:

• a video already in full screen goes black when you request a full screen on an other element

I have no idea how to fix that at this time. I tried to exit and request another full screen operation but it's forbidden as this need to be trigger by a user interaction.

If you want to see that in action: go to twitch, open a stream in full screen and type document.body.requestFullscreen() in your devtool. You'll see that we lost the video :(

Otherwise it will be a much better user experience than my current solution if we fix this issue.

I think it could be also cool if we manage to preserve the theater mode on a fullscreen request. A code like that could do the trick:

document.querySelector('[data-a-target="player-fullscreen-button"]').addEventListener ('click', e => {
  const isTheatreActive = Boolean(document.querySelector('[data-a-player-state="theatre"]'));
  if (!document.fullscreenElement && isTheatreActive) {
    document.body.requestFullscreen();
  }
});

it may conflict with all the other event listener of this button though... even if it does not looks to cause any damage at this time

[night]

thanks for the request. since this has gone stagnant I'm going to close this for now. we'd still be open to a pull request for this feature, but I don't like the idea of a different button for it in the video player (it just generates confusion for users)

[github-actions[bot]]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new pull request for related issues or feature requests.