warn-before-quit icon indicating copy to clipboard operation
warn-before-quit copied to clipboard

Will this extension die after FF57?

Open jjdelc opened this issue 7 years ago • 8 comments

This extension is marked as Legacy in Firefox nightly, which means that it won't be compatible once FF57 launches.

Are there plans to make this into a Web extension?

jjdelc avatar May 03 '17 20:05 jjdelc

I would very much like to. I'm reaching out to the community to see if it's possible.

nigelbabu avatar May 04 '17 03:05 nigelbabu

I am working on converting this add-on to use WebExtensions but I am running into the issue of not knowing how to replace the use of the chrome module used by this add-on to quit the browser. I've uploaded what I have so far to my fork. Right now it does successfully prevent the browser from quitting at least on Mac but without something to replace that API I'm not sure how to finish it. I'll ask for some help in the Mozilla IRC channels tomorrow.

One difference between this new version and the old version is that panels now must be attached to a button in the toolbar. Since that didn't really seem to make sense for this add-on I had to use notifications to replace the panel in the middle of the screen. That seems to work fine but it is a change.

aaronraimist avatar May 19 '17 06:05 aaronraimist

57 is now in the hands of developers and people who live on the edge with Nightly. It'll be in beta before too long. How's the progress on this? :-)

justdave avatar Aug 14 '17 09:08 justdave

From what I know, it's just about impossible to convert this extension to webextensions. I don't get access to shutdown the browser with this one :(

nigelbabu avatar Aug 15 '17 02:08 nigelbabu

@aaronraimist it looks like your fork is a good start ... but it also looks like it will only prevent one Ctrl-Q per launch? Perhaps it would make sense to track when the user tried to hit Ctrl-Q, and suppress the quit if it's either the first press this launch, or if it hasn't been pressed in the last N seconds, where default N would be somewhere in the 5-10 second range (something close to the notification fade-out time?), and maybe user configurable eventually?

IMO, the notification popup is a fine workaround for not being able to do the chrome module any more, so long as it gets dismissed automatically instead of requiring a user click like some notifications do.

fastcat avatar Nov 01 '17 01:11 fastcat

An alternative extension, https://addons.mozilla.org/en-US/firefox/addon/disable-ctrl-q-and-cmd-q/, simply disables the Cmd-Q shortcut. This is good enough for my needs.

mjpieters avatar Jul 19 '18 17:07 mjpieters

Warn on quit is now build in to the browser in about:preferences

Screen Shot 2019-12-05 at 11 06 56 AM

aaronraimist avatar Dec 05 '19 17:12 aaronraimist

That toggle is useful, but not a full replacement for what this extension used to provide:

  • It doesn't do anything unless the Restore previous session is enabled
  • It ignores pinned tabs

fastcat avatar Dec 05 '19 21:12 fastcat