Nick

Results 390 comments of Nick

What's CavernPro? Some sort of paid product / private repo?

Hi @rohitjoins, can you please take a look at this PR? Thanks!

Thanks for the fixes! :)

I'm stopping working on this module: https://github.com/nift4/microg_installer_revived/commit/6a60ec0f9d6fc2d29db3e6119b7a4cff04940c3d just as a heads-up.

My primary concern at this time is PackageValidator: https://github.com/android/uamp/blob/media3/common/src/main/java/com/example/android/uamp/media/PackageValidator.kt and the associated signature list: https://github.com/android/uamp/blob/media3/common/src/main/res/xml/allowed_media_browser_callers.xml because those two are non-trivial to keep up to date, and just being able to...

> As far as I can see, the UAMP filtering has a few more like isWearCompanionApp or isGoogleApp. Do you think it's useful to add these the Media3 as utils?...

I didn't know that existed ;-; thank you! May I suggest extending `isTrusted` to same-UID apps (or just same app) as well? I think that would make sense, and would...

Thanks for investigating, that sounds good.