Opt icon indicating copy to clipboard operation
Opt copied to clipboard

Published 20 hours ago • verified publisher icon niessner

change param name to avoid CUDA solvers runtime error: "nonLinearIter…

Open zhangxaochen opened this issue 5 years ago • 2 comments

…ations" -> "nIterations", "linearIterations" -> "lIterations"

since this commit: https://github.com/niessner/Opt/commit/f96f62640fc0c353414e25752d356fb6d440c7ad#diff-4ec1b09480d2efd4ac57e2db04ec1bdd

the param names have been changed in examples/shape_from_shading/src/CombinedSolver.h

zhangxaochen avatar May 31 '19 05:05 zhangxaochen

Happy to merge the first 3 commits; but the last two seem to be one-off tests.

Mx7f avatar Jun 18 '19 20:06 Mx7f

Thanks for your reply~

I don't quite understand the words one-off tests (not use the PR quite often...), could u explain it a bit?

Does that mean I should close this PR and create another one which contains only the first 3 commits?

BTW, I have one more question on the dimlist parameter of Graph (https://github.com/niessner/Opt/issues/140#issuecomment-503023038). Could you take some time to answer it?

Thank you very much~~~~ :-)

zhangxaochen avatar Jun 19 '19 03:06 zhangxaochen