rust icon indicating copy to clipboard operation
rust copied to clipboard

libgit2-sys: build error with latest 1.61.0 nightly

Open nielx opened this issue 2 years ago • 2 comments

libgit2-sys dependency version in 1.61.0 nightly: "0.13.1+1.4.2" libgit2-sys dependency version in 1.59.0 version = "0.12.24+1.3.0"

The error is a linker error:

  = note: /home/nielx/Haiku/build-r1beta3-x86/cross-tools-x86/lib/gcc/i586-pc-haiku/8.3.0/../../../../i586-pc-haiku/bin/ld: /home/nielx/Rust/rust-nightly/build/x86_64-unknown-linux-gnu/stage1-tools/i686-unknown-haiku/release/deps/liblibgit2_sys-73ecb7e3809c8280.rlib(rand.o): in function `git_rand_global_init':
          rand.c:(.text.git_rand_global_init+0x98): undefined reference to `getloadavg'

It tries to link to the non-POSIX semi common getloadavg() function. This was introduced in libgit2 in 1.4.0.

Solutions:

  • Implement getloadavg() on Haiku
  • Fix libgit2 to have an alternative to getloadavg()

nielx avatar Mar 19 '22 11:03 nielx

https://github.com/libgit2/libgit2/pull/6248

nielx avatar Mar 20 '22 20:03 nielx

Upstream patch accepted, now it is time to wait for a new libgit2 release, and to see when it lands in libgit2-sys

nielx avatar Jul 02 '22 06:07 nielx