recurring-content-detector icon indicating copy to clipboard operation
recurring-content-detector copied to clipboard

Published 20 hours ago • verified publisher icon nielstenboom

Please use better naming convention

Open busterbeam opened this issue 3 years ago • 2 comments

https://github.com/nielstenboom/recurring-content-detector/blob/1ed2d0f1356202af0f43ddffd1e006fe305cb1d9/recurring_content_detector/detector.py#L113-L121

What does s and e mean in your script?? Please use better naming convention

busterbeam avatar Jul 13 '21 01:07 busterbeam

They mean respectively "start frame number" and "end frame number".

pierre-andre-long avatar Jul 13 '21 07:07 pierre-andre-long

@pierre-andre-long is totally right! :)

Agree that some variable naming could be better though, they're artifacts from converting a large jupyter notebook with scientific code to this python module.

nielstenboom avatar Jul 16 '21 12:07 nielstenboom