Niels Dossche

Results 24 comments of Niels Dossche

What metadata besides timestamps do you want to control that you can't control now? Uid and gid come to my mind. > The most obvious thing for me to control...

@theofidry > From a reproducibility perspective the only thing I'm missing is rather clarification of what can cause a PHAR give different signatures. > > We had the case with...

> Filesystem file order is indeed non-deterministic. Could be fixed probably by using a sorted iterator. > > Just to clarify: this is not possible at the moment right? You...

@theofidry I have done performance improvements to different extensions of PHP before, if you give me code I can check what the bottleneck is and try to improve it.

@theseer I've made a draft PR that fixes your problem here: https://github.com/php/php-src/pull/14143 It adds support for having custom SplFileInfo objects. Because Phars only have one timestamp, and it represents the...

https://wiki.php.net/rfc/dom_additions_84 is under discussion which contains the features you need to finish this, as well as some extras such as css selector support. I'd like to point out one thing...

A few minutes ago I merged the final changes to the DOM extension. This includes the methods to get the in scope and descendant namespaces. Unfortunately though this barely missed...

> I was able to make it work with your new additions on the nightly 🚀 There's still something to figure-out with the second point of the description, but that's...

Looks good! Note that the option name is not entirely right though. Both for masterminds/html5 and for PHP's HTML5 support when you disable the namespace usage not only the HTML...

> Alright, I edited the constant name. It's better now I agree. While I cannot comment on anything Symfony specific, the code in general looks pretty good to me. >...