Niels Dossche

Results 24 comments of Niels Dossche

Fwiw this was a php bug and is fixed in 8.1.25 and 8.2.12 (not released yet)

@stof fix for stable versions: https://github.com/php/php-src/pull/12219 fix for master: https://github.com/php/php-src/pull/12246

> Somehow looks like #2602 doesn't have any mention in the upgrading document? Going by memory. This was a fix for https://bugs.php.net/bug.php?id=47137. I.e. the constant was documented on the libxml...

> > * [ ] DOMNameSpaceNode::contains() > > I've checked the PHP-8.3.2 branch and the [PR](https://github.com/php/php-src/commit/ea794e9cde131e6a8679043d2f1a5983f7828245) that was supposed to add this method but couldn't find DOMNameSpaceNode::contains. Maybe this was...

FTR: this shouldn't be merged as this change was undone. I plan on introducing this in another way during the 8.4 cycle though so we can still keep this PR...

(Commented on the GBK test case too, but I know that GH notifications can be weird so just pointing it out so the comment isn't lost). The intention with `discoverNamespace`...

Similarly, [xml_set_element_handler](https://www.php.net/manual/en/function.xml-set-element-handler) etc say stuff like "The function named by start_handler", which is also slightly inaccurate.

The documentation for this method is missing because it was never implemented. i.e. it always threw a "not implemented yet" dom exception, since the very beginning. I placed this on...

Huh, I certainly did not expect BC breaks from that change. In any case, I had a look at this. It seems that you send the test results via stdout,...

@sebastianbergmann how should the API look like? Something like `setTimestamp(string $filename, int|DateTimeInterface $dateTime)` ? That seems doable.