FreeNOS icon indicating copy to clipboard operation
FreeNOS copied to clipboard

Shutdown issue resolved!!

Open NilayGandhi29 opened this issue 4 years ago • 1 comments

Issue #5

Changed the intelCore.h arguments to support the newer versions of the QEMU.

NilayGandhi29 avatar Dec 03 '20 10:12 NilayGandhi29

Hi,

Thanks for solving! Indeed this works on newer Qemu versions. Could you please update your pull request by:

  • squashing the two commit into 1 commit (now it are two commits)
  • provide a single line comment in the commit in the following format: path/to/the/file/or/module: single sentence describing what changed so for your change, it would be for example: lib/libarch/intel/IntelCore: update cpu_shutdown() to support newer Qemu versions
  • please remove the '#include "Endian.h" line, it is not required for this change

Once updated, i will merge your pull request. Thanks, Niek

nieklinnenbank avatar Dec 08 '20 21:12 nieklinnenbank