igel icon indicating copy to clipboard operation
igel copied to clipboard
verified publisher icon nidhaloff

CNN Support Added

Open Prasanna28Devadiga opened this issue 4 years ago • 3 comments

Solves issue #77 Model is configured via the YAML file. Have provided an yaml file example. Tested on Colab. Utilising Keras ensured that we could support a variety of layers besides just the standard Conv2D. Have added docstrings as per the contributing guidelines @nidhaloff Is this adequate? Kindly give me a review

Prasanna28Devadiga avatar Aug 27 '21 13:08 Prasanna28Devadiga

@Prasanna28Devadiga Thanks for the PR. This looks better than the last one. I will review it in detail asap. I may add some comments if I found something that can be optimized or improved

nidhaloff avatar Aug 27 '21 16:08 nidhaloff

@nidhaloff Thank you for the detailed review. This was extremely insightful. As a result I've noticed a few key areas where improvements can be made , and some bug fixes as well. I intend to fix these as soon as possible. I'll even add a few unit tests with the next commit. My university exams are due so might take a bit longer. Let me know if that's fine :)

Prasanna28Devadiga avatar Aug 28 '21 16:08 Prasanna28Devadiga