Webrtc-H264Capturer icon indicating copy to clipboard operation
Webrtc-H264Capturer copied to clipboard

Doesn't work on Windows with WebRTC v62

Open sasmaster opened this issue 7 years ago • 3 comments

Well,it took me 5 days to launch this thing on Windows. Total nightmare. Had to hack the ffmpeg build to get support for formats and codecs used in the demo. But at the end all I got was green screen with some noise at the top. No clue what it it. The video encoded with Codec: H264 - MPEG-4 AVC (part 10) (avc1) . I even suspect that the problem was still on the ffmpeg side. I manually was adding missing headers and sources to the build. Screw Google with their damn ninja thing...

Thanks for the example,anyway.

sasmaster avatar Nov 09 '17 19:11 sasmaster

Thanks for the feedbacks. Not really surprised to read that it has not been a piece of cake to make it run on Windows... The noisy green screen for the local capture preview is "normal" since the new capturer used the YUV buffer to store the H.264 elementary streams => the first noisy lines correspond to the H.264 bistream. I've just committed a new patch (+ some updates in H.264 capturer files). Hope it helps...

2017-11-09 20:14 GMT+01:00 Michael Ivanov [email protected]:

Well,it took me 5 days to launch this thing on Windows. Total nightmare. Had to hack the ffmpeg build to get support for formats and codecs used in the demo. But at the end all I got was green screen with some noise at the top. No clue what it it. The video encoded with Codec: H264 - MPEG-4 AVC (part 10) (avc1) . I even suspect that the problem was still on the ffmpeg side. I manually was adding missing headers and sources to the build. Screw Google with their damn ninja thing...

Thanks for the example,anyway.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nicotyze/Webrtc-H264Capturer/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AMCbnndqqA1KKzQ9mM98-titHXP6Mt3Vks5s0076gaJpZM4QYfw4 .

nicotyze avatar Nov 10 '17 15:11 nicotyze

That's exactly the part I was wondering about. You were submitting the nals from the elementary stream into the Y plane of YUV buffer. Which really doesn't make sense ... So it was kinda hack, right? Any chance you provide paid consulting of some scope?

On Nov 10, 2017 6:55 PM, "Nicolas Tizon" [email protected] wrote:

Thanks for the feedbacks. Not really surprised to read that it has not been a piece of cake to make it run on Windows... The noisy green screen for the local capture preview is "normal" since the new capturer used the YUV buffer to store the H.264 elementary streams => the first noisy lines correspond to the H.264 bistream. I've just committed a new patch (+ some updates in H.264 capturer files). Hope it helps...

2017-11-09 20:14 GMT+01:00 Michael Ivanov [email protected]:

Well,it took me 5 days to launch this thing on Windows. Total nightmare. Had to hack the ffmpeg build to get support for formats and codecs used in the demo. But at the end all I got was green screen with some noise at the top. No clue what it it. The video encoded with Codec: H264 - MPEG-4 AVC (part 10) (avc1) . I even suspect that the problem was still on the ffmpeg side. I manually was adding missing headers and sources to the build. Screw Google with their damn ninja thing...

Thanks for the example,anyway.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nicotyze/Webrtc-H264Capturer/issues/8, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMCbnndqqA1KKzQ9mM98- titHXP6Mt3Vks5s0076gaJpZM4QYfw4> .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nicotyze/Webrtc-H264Capturer/issues/8#issuecomment-343510672, or mute the thread https://github.com/notifications/unsubscribe-auth/AAawgIrC0HVC1ojpHRipSjkkzuNdkjePks5s1HIIgaJpZM4QYfw4 .

sasmaster avatar Nov 10 '17 16:11 sasmaster

Definitely this is a kack. However, in principle it's not that far from v4l2 h.264 "pixel format" which does not really make more sense... So far, I don't provide paid consulting.

2017-11-10 17:12 GMT+01:00 Michael Ivanov [email protected]:

That's exactly the part I was wondering about. You were submitting the nals from the elementary stream into the Y plane of YUV buffer. Which really doesn't make sense ... So it was kinda hack, right? Any chance you provide paid consulting of some scope?

On Nov 10, 2017 6:55 PM, "Nicolas Tizon" [email protected] wrote:

Thanks for the feedbacks. Not really surprised to read that it has not been a piece of cake to make it run on Windows... The noisy green screen for the local capture preview is "normal" since the new capturer used the YUV buffer to store the H.264 elementary streams => the first noisy lines correspond to the H.264 bistream. I've just committed a new patch (+ some updates in H.264 capturer files). Hope it helps...

2017-11-09 20:14 GMT+01:00 Michael Ivanov [email protected]:

Well,it took me 5 days to launch this thing on Windows. Total nightmare. Had to hack the ffmpeg build to get support for formats and codecs used in the demo. But at the end all I got was green screen with some noise at the top. No clue what it it. The video encoded with Codec: H264 - MPEG-4 AVC (part 10) (avc1) . I even suspect that the problem was still on the ffmpeg side. I manually was adding missing headers and sources to the build. Screw Google with their damn ninja thing...

Thanks for the example,anyway.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nicotyze/Webrtc-H264Capturer/issues/8, or mute the thread <https://github.com/notifications/unsubscribe- auth/AMCbnndqqA1KKzQ9mM98- titHXP6Mt3Vks5s0076gaJpZM4QYfw4> .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/nicotyze/Webrtc-H264Capturer/issues/8# issuecomment-343510672>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ AAawgIrC0HVC1ojpHRipSjkkzuNdkjePks5s1HIIgaJpZM4QYfw4> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nicotyze/Webrtc-H264Capturer/issues/8#issuecomment-343515730, or mute the thread https://github.com/notifications/unsubscribe-auth/AMCbnvTpb0Y4fqz8GRliHOBwrQvKa30iks5s1HYJgaJpZM4QYfw4 .

nicotyze avatar Nov 11 '17 20:11 nicotyze