github-with-a-cape icon indicating copy to clipboard operation
github-with-a-cape copied to clipboard

Make it Firefox compatible

Open julkue opened this issue 8 years ago • 6 comments

I'd love to see this in the Firefox marketplace. Since it's a web extension this should be possible easily. You can have e.g. a look at on of my extensions which is using a Grunt build to build the difference manifests.

julkue avatar Jan 22 '17 20:01 julkue

Hello!, I've never built a Firefox extension but I can take a look at your build scripts.

I'll give it a try and get back to you as soon as I can

nicosantangelo avatar Jan 22 '17 22:01 nicosantangelo

Status update: I've submitted the Extension to the Firefox Add-ons page 🎉 I'll let you know when it's approved

nicosantangelo avatar Jan 24 '17 04:01 nicosantangelo

Welp, the Firefox team hasn't reviewed the extension yet, but I think it's available here: https://addons.mozilla.org/en-US/firefox/addon/github-with-a-cape/

nicosantangelo avatar Feb 11 '17 16:02 nicosantangelo

I just installed it and most of it works.

These do not:

  • Show outdated by default
  • Highlight outdated diff icon

Otherwise very happy.

I would love to get a button that can toggle outdated diff comments, any thoughts on that?

tonglil avatar Jun 27 '17 21:06 tonglil

@tonglil

I just installed it and most of it works. These do not: Show outdated by default Highlight outdated diff icon

I'll take a look!

I would love to get a button that can toggle outdated diff comments, any thoughts on that?

You mean toggle all comments at the same time? The only problem I have with adding features to the pull pages is that is a bit hard to find a place where to put stuff. Any ideas?

nicosantangelo avatar Jun 30 '17 09:06 nicosantangelo

Thanks.

I put it here (in my own sort of extension): image

It shows both the branch name, as well as provides expansion/collapse (toggle) functionality.

tonglil avatar Jun 30 '17 15:06 tonglil